Avoid a11y redundancy tips

[cary-rowen]

Operating system

Windows

Joplin version

Joplin 3.3.2 (prod, win32)

Desktop version info

Joplin 3.3.2 (prod, win32)

Client ID: 17b8b34f41864e5ca64c12f4551338fb
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: 200d3c8

Backup: 1.4.2
Freehand Drawing: 2.15.0

Current behaviour

1. Open Joplin and NVDA screenreader.
2. Press Ctrl+Shift+S, focus on the sidebar.
3. Press upArrow / Downarron to navigate in treeView.
4. NVDA will reporting:
   • "Trash Expanded, press space to collapse. expanded"
   • "No notes in here. Create one by clicking on "New note"."
   • "This subfolder of the trash has no notes. "

Expected behaviour

In a series of tips in step (4) I think there is some redundancy:

e.g.

"Trash Expanded, press space to collapse. expanded"
This is not necessary, because the screen reader will report the tree view state, and the screen reader user will be able to infer how it should expand or collapse according to the state and role of the control.

"No notes in here. Create one by clicking on "New note"."
"This subfolder of the trash has no notes. "

This may not be necessary, for the number of notes that we have supported the report containing notes, if we do not include any notes, we do not report anything, or report "Contains 0 notes"

Logs

No response

[cary-rowen]

I'm really happy to see a series of recent efforts by Joplin on A11y, which is very useful for screen reader users.

[personalizedrefrigerator]

Thank you for the feedback!

"Trash Expanded, press space to collapse. expanded"

I'm linking to the relevant code:

joplin/packages/app-desktop/gui/Sidebar/listItemComponents/ExpandIcon.tsx

Line 26 in 0635983

return _('Expanded, press space to collapse.');

This label was present originally because the "expand"/"collapse" icons were individually focusable buttons (older versions of Joplin did not properly use the treeview pattern). Whether a folder is expanded/collapsed is now communicated through aria- properties. As such, this label should no longer be necessary.

"No notes in here. Create one by clicking on "New note"."
"This subfolder of the trash has no notes. "

This may be related to giving the "No notes in here. ..." message the status role. This is done to notify the user when there are no results (when using the standard search). Here are some options:

• Only give the "No notes in here. ..." message the status role if currently searching.
• Include the number of search results in a separate status live region.
• Follow the Combobox Pattern for search and search results (similar to the Goto Anything dialog).