Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we keep this up to date with changes to Refined Github? #19

Open
wearhere opened this issue Oct 1, 2020 · 4 comments
Open

How do we keep this up to date with changes to Refined Github? #19

wearhere opened this issue Oct 1, 2020 · 4 comments

Comments

@wearhere
Copy link

wearhere commented Oct 1, 2020

Especially if we're building the app ourselves to add support for GitHub Enterprise #8 (comment).

@lautis
Copy link
Owner

lautis commented Oct 2, 2020

There's two sides for this:

  1. How to keep the codebase up-to-date with refined-github
  2. How to keep app installations updated

For the second problem, publishing to Mac App Store would seem to be the best option. Unfortunately that process is not instant and trademarks might make it harder to get to the App Store. Homebrew seems like a reasonable fallback option but requires user interaction. I guess having Sparkle or similar self-update functionality wouldn't hurt. However, they require user interaction, and I don't at least open the .app very often.

To keep things up-to-date is rather simple by running fastlane update_refined_github. That would be easy to automate with GitHub Actions, but then also having automation to publish new versions would be needed to provide value.

1 and 2 are a bit conflicting unless confidence for automation would be high enough to publish to App Store without any manual checks.

@lautis
Copy link
Owner

lautis commented Oct 2, 2020

As for GitHub Enterprise, it might be easiest to implement a second extension running all domains and via app settings control which domains actually load the code. Unless changing manifest within runtime is allowed in Safari 14.

@notlmn
Copy link

notlmn commented Oct 2, 2020

As for GitHub Enterprise, it might be easiest to implement a second extension running all domains and via app settings control which domains actually load the code

Is this through additional inputs in the extension's settings view?

@lautis
Copy link
Owner

lautis commented Oct 2, 2020

GitHub access token is set through the .app, but I haven’t looked at how it should work with WebExtensions API or what the implementation in refined-github now looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants