-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do we keep this up to date with changes to Refined Github? #19
Comments
There's two sides for this:
For the second problem, publishing to Mac App Store would seem to be the best option. Unfortunately that process is not instant and trademarks might make it harder to get to the App Store. Homebrew seems like a reasonable fallback option but requires user interaction. I guess having Sparkle or similar self-update functionality wouldn't hurt. However, they require user interaction, and I don't at least open the .app very often. To keep things up-to-date is rather simple by running 1 and 2 are a bit conflicting unless confidence for automation would be high enough to publish to App Store without any manual checks. |
As for GitHub Enterprise, it might be easiest to implement a second extension running all domains and via app settings control which domains actually load the code. Unless changing manifest within runtime is allowed in Safari 14. |
Is this through additional inputs in the extension's settings view? |
GitHub access token is set through the .app, but I haven’t looked at how it should work with WebExtensions API or what the implementation in refined-github now looks like. |
Especially if we're building the app ourselves to add support for GitHub Enterprise #8 (comment).
The text was updated successfully, but these errors were encountered: