Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tolerate TOC tree with no items #2039

Merged
merged 1 commit into from
Sep 17, 2024
Merged

tolerate TOC tree with no items #2039

merged 1 commit into from
Sep 17, 2024

Conversation

longhotsummer
Copy link
Contributor

fixes #1988

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Test Results

1 tests   - 48   1 ✅  - 48   0s ⏱️ -11s
1 suites  - 12   0 💤 ± 0 
1 files    - 12   0 ❌ ± 0 

Results for commit 1b37a5b. ± Comparison against base commit 55f5fc5.

This pull request removes 49 and adds 1 tests. Note that renamed tests count towards both. 
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_docx_swap_pdf
peachjam.tests.test_admin.TestJudgmentAdmin ‑ test_add_judgment_pdf_swap_docx
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_number_import_without_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_case_numbers_with_matter_type
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_import_with_taxonomy
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_judgment_bulk_import
peachjam.tests.test_bulk_import.JudgmentBulkImportTestCase ‑ test_source_file_prefers_docx_over_pdf
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_delete_citations_should_not_change_akn
peachjam.tests.test_citations.CitationAnalyserTestCase ‑ test_pdf_extractions
…

africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage

♻️ This comment has been updated with latest results.

actlikewill
actlikewill approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@actlikewill actlikewill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@longhotsummer longhotsummer merged commit 3feadb7 into main Sep 17, 2024
9 checks passed
@longhotsummer longhotsummer deleted the toc-items branch September 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actlikewill actlikewill actlikewill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'children')
2 participants
@longhotsummer @actlikewill