Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sistent] Move code section of identity to table format #5668

Open
sudhanshutech opened this issue Jul 11, 2024 · 20 comments · May be fixed by #5801
Open

[Sistent] Move code section of identity to table format #5668

sudhanshutech opened this issue Jul 11, 2024 · 20 comments · May be fixed by #5801
Assignees
Labels
component/ui Issues related to UI kind/enhancement New feature or request

Comments

@sudhanshutech
Copy link
Member

Current Behavior

The identity section under https://layer5.io/projects/sistent/identity/color like color, typography and spacing these sections code part is currently a image so user can't copy the color code.

Desired Behavior

Move these images to table format instead of images, same structure just use table to display the colors and rest code section of identity.
Design can be found here: Figma

Screenshots / Mockups

Implementation

Acceptance Tests


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@sudhanshutech sudhanshutech added kind/enhancement New feature or request component/ui Issues related to UI labels Jul 11, 2024
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Aviral0702
Copy link

For color -> code section an issue has already been opened.

@Aviral0702
Copy link

layer5io/sistent#646

@Aviral0702
Copy link

Ok . Can i take up this issue ?

@mannika763
Copy link
Contributor

Hey @sudhanshutech
I would like to work on this issue

@sudhanshutech
Copy link
Member Author

@Aviral0702 you have few issues assigned in meshery , lets give this issue to @mannika763 and you can assist and review the pr when it will be raised.

@Aviral0702
Copy link

@Aviral0702 you have few issues assigned in meshery , lets give this issue to @mannika763 and you can assist and review the pr when it will be raised.

Sure @sudhanshutech

@mannika763
Copy link
Contributor

Hey @sudhanshutech
I would like to confirm a few things. These images need to be converted into code form. We have sections for color, spacing, and typography, and within each of them, we have overview, guidance, and code. Should these changes be applied to each section?

@sudhanshutech
Copy link
Member Author

In code section, just put the colors in table and ui should be same as current just it should not be a image but content inside table

@sudhanshutech
Copy link
Member Author

@mannika763 i am seeing you are already working on a issue, will you be managing this also?

@mannika763
Copy link
Contributor

@sudhanshutech
yeah, can manage. otherwise i'll post a message here.
Thank you for asking

@mannika763
Copy link
Contributor

Hey @sudhanshutech,
I would like to confirm if there is any table-related component available in Layer5, or should I create table from scratch?
Thanks!

@mannika763
Copy link
Contributor

Hey @sudhanshutech
I apologize for any inconvenience,
but I am currently a bit busy with my work. Therefore, I am unassigning this task from my name so that others can work on it and close it earlier.
Thank you for your understanding.

@mannika763 mannika763 removed their assignment Jul 25, 2024
@siddharthbaleja7
Copy link
Contributor

@sudhanshutech Can you please assign this issue to me?

@sudhanshutech
Copy link
Member Author

here you go @siddharthbaleja7

@sudhanshutech
Copy link
Member Author

you are aware of the issue right @siddharthbaleja7 ?

@siddharthbaleja7
Copy link
Contributor

@sudhanshutech Sorry I am not aware of this issue.

@siddharthbaleja7 siddharthbaleja7 removed their assignment Aug 2, 2024
@BarryByte
Copy link

@sudhanshutech Hello, @siddharthbaleja7 just unassigned himself, can i take it issue forward ?

@BarryByte
Copy link

@sudhanshutech Update : Styling and logic part is complete, now i just need to harcode the 100s token, values and description etc.
Here is the sample, please look into it.
Screenshot from 2024-08-07 01-56-16
Screenshot from 2024-08-07 01-56-23

@BarryByte BarryByte linked a pull request Aug 9, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issues related to UI kind/enhancement New feature or request
5 participants