From 3ef36dc7b1b8d9a0807b8bb064c38a5a96e47ae0 Mon Sep 17 00:00:00 2001 From: Michael Wetter Date: Wed, 18 Oct 2023 15:49:15 -0700 Subject: [PATCH] Added missing units --- Buildings/Controls/OBC/ASHRAE/G36/Generic/TimeSuppression.mo | 2 +- .../OBC/ASHRAE/G36/TerminalUnits/CoolingOnly/Controller.mo | 4 ++-- .../G36/TerminalUnits/DualDuctColdDuctMin/Controller.mo | 4 ++-- .../TerminalUnits/DualDuctMixConDischargeSensor/Controller.mo | 4 ++-- .../G36/TerminalUnits/DualDuctMixConInletSensor/Controller.mo | 4 ++-- .../ASHRAE/G36/TerminalUnits/DualDuctSnapActing/Controller.mo | 4 ++-- .../OBC/ASHRAE/G36/TerminalUnits/ParallelFanCVF/Controller.mo | 4 ++-- .../OBC/ASHRAE/G36/TerminalUnits/ParallelFanVVF/Controller.mo | 4 ++-- .../OBC/ASHRAE/G36/TerminalUnits/Reheat/Controller.mo | 4 ++-- .../OBC/ASHRAE/G36/TerminalUnits/SeriesFanCVF/Controller.mo | 4 ++-- .../OBC/ASHRAE/G36/TerminalUnits/SeriesFanVVF/Controller.mo | 4 ++-- 11 files changed, 21 insertions(+), 21 deletions(-) diff --git a/Buildings/Controls/OBC/ASHRAE/G36/Generic/TimeSuppression.mo b/Buildings/Controls/OBC/ASHRAE/G36/Generic/TimeSuppression.mo index cf04741000d..d4450ea3f2c 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/Generic/TimeSuppression.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/Generic/TimeSuppression.mo @@ -3,7 +3,7 @@ block TimeSuppression "Calculate a time-delay period after change in set point" parameter Real chaRat(final unit="s/K")=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC. For cooling or heating request, it should be 540 seconds, for temperature alarms, it should be 1080 seconds" + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin. For cooling or heating request, it should be 540 seconds, for temperature alarms, it should be 1080 seconds" annotation (__cdl(ValueInReference=true)); parameter Real maxTim( final unit="s", diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/CoolingOnly/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/CoolingOnly/Controller.mo index 34511e1d638..bda4d434f59 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/CoolingOnly/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/CoolingOnly/Controller.mo @@ -106,8 +106,8 @@ block Controller "Controller for cooling only VAV box" parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctColdDuctMin/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctColdDuctMin/Controller.mo index 3a43316354a..73f3e9c9c29 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctColdDuctMin/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctColdDuctMin/Controller.mo @@ -100,8 +100,8 @@ block Controller "Controller for dual-duct terminal unit with cold-duct minimum "Threshold time to check damper leaking airflow" annotation (__cdl(ValueInReference=true), Dialog(tab="Alarms")); // ---------------- Parameters for time-based suppression ---------------- - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConDischargeSensor/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConDischargeSensor/Controller.mo index 644d1a2c7e7..fef738ca794 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConDischargeSensor/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConDischargeSensor/Controller.mo @@ -102,8 +102,8 @@ block Controller "Controller for dual-duct terminal unit using mixing control wi "Threshold time to check damper leaking airflow" annotation (__cdl(ValueInReference=true), Dialog(tab="Alarms")); // ---------------- Parameters for time-based suppression ---------------- - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConInletSensor/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConInletSensor/Controller.mo index 3ce918ba62d..b8112dbc3cb 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConInletSensor/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctMixConInletSensor/Controller.mo @@ -100,8 +100,8 @@ block Controller "Controller for dual-duct terminal unit using mixing control wi "Threshold time to check damper leaking airflow" annotation (__cdl(ValueInReference=true), Dialog(tab="Alarms")); // ---------------- Parameters for time-based suppression ---------------- - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctSnapActing/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctSnapActing/Controller.mo index 9dd3fd5abd2..5d6c8ef710f 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctSnapActing/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/DualDuctSnapActing/Controller.mo @@ -113,8 +113,8 @@ block Controller "Controller for snap-acting controlled dual-duct terminal unit" "Threshold time to check valve leaking water flow" annotation (__cdl(ValueInReference=true), Dialog(tab="Alarms")); // ---------------- Parameters for time-based suppression ---------------- - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanCVF/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanCVF/Controller.mo index 0f4c58df92a..735a0ed3574 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanCVF/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanCVF/Controller.mo @@ -160,8 +160,8 @@ block Controller "Controller for constant-volume parallel fan-powered terminal u parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanVVF/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanVVF/Controller.mo index 1dbd54e4fa7..e9375312771 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanVVF/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/ParallelFanVVF/Controller.mo @@ -164,8 +164,8 @@ block Controller parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/Reheat/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/Reheat/Controller.mo index 1aefa5bc6ab..bc0453893e6 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/Reheat/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/Reheat/Controller.mo @@ -168,8 +168,8 @@ block Controller "Controller for room VAV box with reheat" parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanCVF/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanCVF/Controller.mo index 50e80f979f7..c3dd11f9622 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanCVF/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanCVF/Controller.mo @@ -157,8 +157,8 @@ block Controller "Controller for constant-volume series fan-powered terminal uni parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time" diff --git a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanVVF/Controller.mo b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanVVF/Controller.mo index 70fd7409959..a3c5fffcf28 100644 --- a/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanVVF/Controller.mo +++ b/Buildings/Controls/OBC/ASHRAE/G36/TerminalUnits/SeriesFanVVF/Controller.mo @@ -162,8 +162,8 @@ block Controller parameter Real samplePeriod(unit="s")=120 "Sample period of component, set to the same value as the trim and respond that process static pressure reset" annotation (__cdl(ValueInReference=false), Dialog(tab="Time-based suppresion")); - parameter Real chaRat=540 - "Gain factor to calculate suppression time based on the change of the setpoint, second per degC" + parameter Real chaRat(final unit="s/K")=540 + "Gain factor to calculate suppression time based on the change of the setpoint, seconds per Kelvin" annotation (__cdl(ValueInReference=true), Dialog(tab="Time-based suppresion")); parameter Real maxSupTim(unit="s")=1800 "Maximum suppression time"