Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strikethrough Formatting does not transfer to LBRY Post #32

Open
cahlenlee opened this issue May 24, 2020 · 1 comment
Open

Strikethrough Formatting does not transfer to LBRY Post #32

cahlenlee opened this issue May 24, 2020 · 1 comment

Comments

@cahlenlee
Copy link

cahlenlee commented May 24, 2020

DESCRIPTION:
Using Strikethrough formatting in a Wordpress post does not carry over to the LBRY version of the post.


REPRO STEPS:

  1. Log into self-hosted Wordpress site w/ LBRYPress Plugin
  2. Create a new Post
  3. Create a Paragraph Block
  4. Enter text and format with Strikethrough
  5. Publish and review on LBRY

Results: Strikethrough formatting is missing

Expected: Strikethrough formatting is present


ENVIRONMENT:
Ubuntu 18.04.4
WordPress 5.3.3
PHP 7.2.24
LBRYPress 0.0.1
Lodestar Theme 1.0.8


IMAGES:

LBRYPress_0 1 1_TextColorLBRY

LBRYPress_0 1 1_TextColorWordpress


LBRY ADDRESS:
bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b
[email protected]

@QuirkyRobots
Copy link

QuirkyRobots commented May 27, 2020

According to the "HTML To Markdown for PHP" documentation,

Markdown Extra, MultiMarkdown and other variants aren't supported – just Markdown.

Which as far as I'm aware doesn't include strikethrough.

In the Elements file, I don't see it registered:

    public function isBlock()
    {
        switch ($this->getTagName()) {
            case 'blockquote':
            case 'body':
            case 'code':
            case 'div':
            case 'h1':
            case 'h2':
            case 'h3':
            case 'h4':
            case 'h5':
            case 'h6':
            case 'hr':
            case 'html':
            case 'li':
            case 'p':
            case 'ol':
            case 'ul':
                return true;
            default:
                return false;
        }
    }

I guess it would have to be added to the converter here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants