Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when notification is generated via FCM #71

Open
Abadulrehman opened this issue Aug 24, 2021 · 0 comments
Open

Error when notification is generated via FCM #71

Abadulrehman opened this issue Aug 24, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Abadulrehman
Copy link
Collaborator

When choosing to create a Notification with FCM as the channel, the subject field is hidden, and so it cannot be defined. Because of that, whenever the notification is triggered, it fails with a NoneType error.

The check in question:

renovation_core/renovation_core/utils/notification.py

Lines 52 to 53 in 6749be6

title = notification.subject
if "{" in title:

Subject field is hidden when FCM is selected:
Screenshot from 2021-08-24 12-39-08
@Abadulrehman Abadulrehman changed the title Error when notification in generated via FCM Error when notification is generated via FCM Aug 24, 2021
@assemmarwan assemmarwan added the good first issue Good for newcomers label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@assemmarwan @Abadulrehman