Skip client namespace checks for methods with inline body. #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client namespace checks are skipped for functions that have bodies, if
FunctionDecl::hasBody()
returns true. For the following function,FunctionDecl::hasBody()
returns false.hasInlineBody()
does return true, and also skipping the check whenhasInlineBody()
returns true "fixes" the issue and allows the above code to compile.I don't really understand why
hasBody()
returns false here, or whyhasInlineBody()
does not implyhasBody()
.