Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rename the subject #7

Open
sirion1987 opened this issue Jun 21, 2019 · 0 comments
Open

Don't rename the subject #7

sirion1987 opened this issue Jun 21, 2019 · 0 comments

Comments

@sirion1987
Copy link
Contributor

# good
RSpec.describe Foo do
  subject { described_class.new }

  it 'is valid' do
    expect(subject.valid?).to be(true)
  end
end
# bad
RSpec.describe Foo do
  # Foo or user?
  subject(:user) { described_class.new }

  it 'is valid' do
    expect(user.valid?).to be(true)
  end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant