Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include demo widgets in release archive #19

Open
Vtec234 opened this issue Aug 3, 2023 · 0 comments
Open

Don't include demo widgets in release archive #19

Vtec234 opened this issue Aug 3, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Vtec234
Copy link
Collaborator

Vtec234 commented Aug 3, 2023

Currently, lake build will build all widget/*.tsx files and place them under build/js. This is great for getting demos running easily, but we also use the same build target to create the .tar.gz archives that are distributed to packages that import ProofWidgets. This means that JS code built only for demos, including bundled libraries from NPM, ends up bloating the size of the archive. As of today it is not too bad - just 7M - but it could become a concern as we add more demos that bundle in large libraries. We should better have a separate archive target which produces the JS needed for ProofWidgets.lean and nothing more. It would be even better if Lake could do this for us.

Perhaps instead of a separate target, it would be better to have an enable_demos Lake option.

@Vtec234 Vtec234 added enhancement New feature or request help wanted Extra attention is needed labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant