Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpNF should use dsimp for lemmas proved by rfl #86

Open
digama0 opened this issue Jan 13, 2023 · 1 comment
Open

simpNF should use dsimp for lemmas proved by rfl #86

digama0 opened this issue Jan 13, 2023 · 1 comment

Comments

@digama0
Copy link
Member

digama0 commented Jan 13, 2023

The @[simp] attribute is used by both simp and dsimp, so it is possible for a rfl lemma to have a proof by simp but not one by dsimp, and so this is a false positive. The linter should check if the current declaration is a rfl lemma and if so restrict its attention to dsimp proofs.

@kim-em
Copy link
Collaborator

kim-em commented Aug 6, 2023

I've just updated the links in mathlib4 pointing to mathlib4#5081 to point to this issue instead.

This link searches for references to this issue in the mathlib4 source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants