From 245026cbda65f96ea11cf47a2b5a3282902adb08 Mon Sep 17 00:00:00 2001 From: Vincent ENJALBERT Date: Sat, 16 Feb 2019 12:12:04 +0100 Subject: [PATCH 1/3] pass $modal to modal-partial-end view #98 --- src/Facades/Modal.php | 2 +- src/ModalRenderer.php | 5 +++-- src/Stubs/Modal.txt | 2 +- src/resources/views/modal/form-sample.blade.php | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Facades/Modal.php b/src/Facades/Modal.php index bf35cce..5acce78 100644 --- a/src/Facades/Modal.php +++ b/src/Facades/Modal.php @@ -10,7 +10,7 @@ /** * @method static void start(array $data) - * @method static void end() + * @method static void end(array $data) */ class Modal extends Facade { diff --git a/src/ModalRenderer.php b/src/ModalRenderer.php index e0ac393..b9d8a6e 100644 --- a/src/ModalRenderer.php +++ b/src/ModalRenderer.php @@ -22,10 +22,11 @@ public function start($data) /** * Render the modal closing section * + * @param $data * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View */ - public function end() + public function end($data) { - return view('leantony::modal.modal-partial-end'); + return view('leantony::modal.modal-partial-end', ['modal' => $data]); } } \ No newline at end of file diff --git a/src/Stubs/Modal.txt b/src/Stubs/Modal.txt index bba4d81..8e72670 100644 --- a/src/Stubs/Modal.txt +++ b/src/Stubs/Modal.txt @@ -6,4 +6,4 @@ placeholder="Enter {{ input }}" value="{{ isset(${{ input }}) ? $data->{{ input }} : old('{{ input }}')}}"> -{!! Modal::end() !!} \ No newline at end of file +{!! Modal::end($modal) !!} \ No newline at end of file diff --git a/src/resources/views/modal/form-sample.blade.php b/src/resources/views/modal/form-sample.blade.php index 8197e0a..7933be1 100644 --- a/src/resources/views/modal/form-sample.blade.php +++ b/src/resources/views/modal/form-sample.blade.php @@ -13,4 +13,4 @@ name="email" placeholder="Enter email" value="{{ isset($user) ? $user->email : old('email')}}"> -{!! Modal::end() !!} \ No newline at end of file +{!! Modal::end($modal) !!} \ No newline at end of file From 1252e8f62131a6ec1274607070b7617dcd7d7826 Mon Sep 17 00:00:00 2001 From: Vincent ENJALBERT Date: Sat, 16 Feb 2019 12:13:37 +0100 Subject: [PATCH 2/3] retrocompatibility fix --- src/ModalRenderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ModalRenderer.php b/src/ModalRenderer.php index b9d8a6e..83fb3f7 100644 --- a/src/ModalRenderer.php +++ b/src/ModalRenderer.php @@ -25,7 +25,7 @@ public function start($data) * @param $data * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View */ - public function end($data) + public function end($data = []) { return view('leantony::modal.modal-partial-end', ['modal' => $data]); } From 545e4ded78c669cd71f6158533fb102f1150d223 Mon Sep 17 00:00:00 2001 From: Vincent ENJALBERT Date: Sat, 2 Mar 2019 17:36:24 +0100 Subject: [PATCH 3/3] Bugfix : display search form only if shouldRenderSearchForm is true --- src/resources/views/grid/grid.blade.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/resources/views/grid/grid.blade.php b/src/resources/views/grid/grid.blade.php index 481624c..e93d50f 100644 --- a/src/resources/views/grid/grid.blade.php +++ b/src/resources/views/grid/grid.blade.php @@ -16,7 +16,9 @@ @endif + @if($grid->shouldRenderSearchForm())
+ @endif