Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the basePath relative to the sync-db.yml path instead of current working directory. #225

Closed
silwalanish opened this issue Sep 30, 2023 · 3 comments · Fixed by #237
Closed

Resolve the basePath relative to the sync-db.yml path instead of current working directory. #225

silwalanish opened this issue Sep 30, 2023 · 3 comments · Fixed by #237
Assignees
@samirsilwal
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest improvement

Comments

@silwalanish
Copy link
Member

silwalanish commented Sep 30, 2023 •
edited
Loading

Resolve the basePath relative to the sync-db.yml path instead of current working directory.

Issue recreated here: https://github.com/silwalanish/sync-db-bug-reports/tree/main/base-path-resolution

image
@silwalanish silwalanish added the bug Something isn't working label Sep 30, 2023
@silwalanish silwalanish changed the title synchronize should resolve the path relative to the sync-db.yml path instead of current working directory. Resolve the basePath relative to the sync-db.yml path instead of current working directory. Sep 30, 2023
@silwalanish
Copy link
Member Author

Also @mesaugat I think we should also be able to pass config file as relative path in the loadConfig function and in --config CLI argument.

@samirsilwal samirsilwal self-assigned this Oct 7, 2024
@samirsilwal
Copy link
Collaborator

@silwalanish Will look into this issue 🥂

@samirsilwal
Copy link
Collaborator

#237 should address the issue. Tested with few cases. Will notify when completed.

@mesaugat mesaugat mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samirsilwal samirsilwal

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use relative base path respective to config file leapfrogtechnology/sync-db
3 participants
@mesaugat @silwalanish @samirsilwal