-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing error handling in Data type microservice #104
Comments
Nop, there are a treatment in each microservice to respond mishandled requests, in this case is returned a bad request error, do you think which is necessary add all response errors in docs? |
And sorry to respond after 6 days, i didn't see the github notification. |
|
when a bad request is accomplished, also is returned a message informating the error with the bad request status (406), in data type handler. There are the "invalid_fields", "invalid_filename" and "missing_fields" messages in DataTypeHandlerRequestValidator class, i think which errors responses already are implemented by each microservices, the user will be informed what is the error in case of bad request. |
Bug description
I'm not entirely certain because I was not able to test it, but I believe the Data type microservice is missing some error handling in data_type_handler.py
For example, if one tries to cast "Hello world" into a float Python will return an error, but there's nothing to catch that error.
Expected result
Either replace the un-castable values by None, or abort the Data type command?
Actual result
Crash?
The text was updated successfully, but these errors were encountered: