Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests in microservices #90

Open
learningOrchestraAccount opened this issue Oct 4, 2020 · 21 comments
Open

Implement tests in microservices #90

learningOrchestraAccount opened this issue Oct 4, 2020 · 21 comments
Assignees
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@learningOrchestraAccount
Copy link
Member

learningOrchestraAccount commented Oct 4, 2020

Is your feature request related to a problem? Please describe.

Currently the microservices are hard to make tests, when a PR is created, we need deploy learningOrchestra in a cloud cluster to verify the changes, it is painful!

Describe the solution you'd like

There are a way to make tests in each microservice to ensure the correct working? I don't know a exactly solution.

Describe alternatives you've considered

Maybe we can use mocked files to test each microservice.

Additional context

The microservices are highly coupled, each microservice have rely to other microservices.

@learningOrchestraAccount learningOrchestraAccount added hacktoberfest help wanted Extra attention is needed enhancement New feature or request labels Oct 4, 2020
@riibeirogabriel
Copy link
Member

@sudiptog81 do you have knowledge to help us with this issue?

@sudiptog81
Copy link
Contributor

@riibeirogabriel I have written tests for REST APIs, I would need to deploy this project to get a feel, working on this. Microservices would need to be distributed across repositories and added as submodules to this repository at some point, when the tight-coupling has been taken care of.

There could be unit tests for each microservice that can be run as separate CI jobs for individual branches and integration test jobs can be run for the master.

@riibeirogabriel
Copy link
Member

@sudiptog81 it sounds like a big challengue!
If we put each microservice in a repo, how we will make the deploy of the learningOrchestra?
The user will clone each repo in a subfolder like the microservices?
It will be painful.

@sudiptog81
Copy link
Contributor

They are separate ideas. Regarding cloning, the --recursive flag shall take care of that, but that idea is for the future. Right now, we can work on individual unit tests and then run all the unit tests using a test script. I still need to work on how to deploy the cluster from a CI environment after tests have run.

@riibeirogabriel
Copy link
Member

You will be very help to this project, i don't know a way to use CI tests with a distributed software, without make the deploy, maybe using mock files.

@riibeirogabriel
Copy link
Member

Do you have a cluster environment (3 machines) to run this software and know how it works?

@riibeirogabriel
Copy link
Member

Maybe can run with 2 machines.

@riibeirogabriel
Copy link
Member

@all-contributors please add @hiperbolt for code and ideas

@allcontributors
Copy link
Contributor

@riibeirogabriel

I've put up a pull request to add @hiperbolt! 🎉

@hiperbolt
Copy link

@sudiptog81 I suggest maybe an azure pipeline with pre-made mock files. I'm interested on how this issue gets fixed.

@riibeirogabriel
Copy link
Member

@sudiptog81 Would you like make this issue together with @hiperbolt ?

@riibeirogabriel
Copy link
Member

@sudiptog81 Do you yet have interest in this issue? Case negative i can pass to other person.

@sudiptog81
Copy link
Contributor

Please unassign me from this particular issue and pass on, kind of busy for a few days.

@riibeirogabriel
Copy link
Member

@sudiptog81 no problems, if you have future interest, please send me a message.

@riibeirogabriel
Copy link
Member

@hiperbolt do you can this alone?

@hiperbolt
Copy link

@riibeirogabriel Yeah I think I can work on this on my own.

@riibeirogabriel
Copy link
Member

I can help you, but i have little knowledge on microservices test, i think this require some studies about.

@hiperbolt
Copy link

I'll take my time researching it. I'll talk to you about ideas on how to approach this.

@hiperbolt
Copy link

I'm going with unit tests with mockfiles for each microservice, using github/azure pipelines for CI/CD. I'm going to start work on the mock files and unit tests and once those are done I'll update here.

@hiperbolt
Copy link

Sorry I haven't been active on this issue. I'm going to start work on it today.

@riibeirogabriel
Copy link
Member

@hiperbolt no problem, take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants