Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage lesson resources - Navigation issues #13073

Open
pcenov opened this issue Feb 12, 2025 · 3 comments
Open

Manage lesson resources - Navigation issues #13073

pcenov opened this issue Feb 12, 2025 · 3 comments
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Feb 12, 2025

Observed behavior

The first issue is that if I have already 'added' a resource when I click on the 'N resources selected' link and then go back and click the 'Remove' button then I am incorrectly returned to the 'N resources selected' page:

addandremovenavigation.mp4

Also when I add/remove a resource I am immediately brought back to the previous page which is a bit confusing (especially when working with multiple similar resources) as I'm not sure what has happened, since there's no confirmation and everything is happening really fast. The same scenario is valid when adding/removing resources from the search results.
It seems that it will be better to leave the user at the same page, as there will be a clear indication that the item has been added or removed by the labels 'Added' and 'Removed' and the user will be able to navigate back whenever they wish to do so:

arm.mp4

Lastly, we have the back arrow everywhere else, but it's not present when previewing a resource - seems that it would be great to have it there as well!

Expected behavior

Smoother user navigation as described above.

Steps to reproduce the issue

  1. Install the Kolibri 0.18 alpha1 build
  2. Navigate to Class > Lessons > Lesson and click "Manage resources"
  3. Click on a resource and add it.
  4. Reopen the resource, click the 'N resources selected' link, then go back and remove the resource.

Usage Details

Kolibri 0.18 alpha1
Windows 11, Ubuntu 22 - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented Feb 12, 2025

@radinamatic @marcellamaki

@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Feb 12, 2025
@marcellamaki
Copy link
Member

Hi @pcenov - just to clarify, the main confusion/problem (aside from the back arrow that you mention) is that when you are adding and removing a resource from the "preview", you are redirected back to whatever you were on previously - whether that be the "shopping cart", search results, etc. It's kind of the equivalent of hitting the browser back button, in the sense that it's except it's happening for you, and you don't see any sort of conformation of the change that you made. Is that right?

@pcenov
Copy link
Member Author

pcenov commented Feb 14, 2025

Hi @marcellamaki - yes, that's the main problem - that after adding/removing from the preview, one is always returned to the previous screen. But also even the existing text "Added" is confusing because there's a big difference between an actually added resource and a resource which is only selected and will be added to the lesson after pressing "Save & finish".
Note that if I have already added a resource to a lesson when I open the "Menage lesson resources" panel, then when I preview the same resource it is also marked as "Added" while the "Remove" button is disabled (from the perspective of a user who's interacting with it for the first time, this looks like a bug, along with the disabled checkboxes).

Looking globally at the current implementation a user can only select and deselect items while viewing for the first time when there are still no resources added to the lesson. When we enter in the second case where there are added resources, one can no longer remove them from the side panel, but can still add new ones, which when selected will be labeled as "Added" in the preview, even before the user has clicked the "Save & finish" button!

added.or.not.added.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

3 participants