Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core logic for the importchannel command is migrated to utility functions and all associated tasks updated #13095

Open
Tracked by #9266
rtibbles opened this issue Feb 19, 2025 · 1 comment · May be fixed by #13099
Open
Tracked by #9266

Comments

@rtibbles
Copy link
Member

rtibbles commented Feb 19, 2025

Currently all the logic for the importchannel command lives inside the management command class. This means that when we want to run an asynchronous task, all it does is end up wrapping the management command in a task, making it harder to test the individual behaviour.

To resolve this, the main logic for actually downloading the channel database and running the import should be abstracted out into separate utility functions in a kolibri.core.content.utils submodule, and then reused in the management command and in the tasks that use it.

@rtibbles rtibbles changed the title importchannel command is migrated and all associated tasks updated Core logic for the importchannel command is migrated to utility functions and all associated tasks updated Feb 19, 2025
@thesujai
Copy link
Contributor

Hi @rtibbles, commenting to claim this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants