Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve nonce issues with new mempool nonces from API? #1193

Open
Hero-Gamer opened this issue May 8, 2023 · 7 comments
Open

Resolve nonce issues with new mempool nonces from API? #1193

Hero-Gamer opened this issue May 8, 2023 · 7 comments
Labels
Bug 🐛 Functionality broken Nonce P2 Bug 🕷 Critical functionality broken for few users, with no clear workarounds

Comments

@Hero-Gamer
Copy link

A. Sent 1 tx successfully with correct nonce
B. Tried sending 2nd tx afterwards, in preview window it says the same nonce as the 1st transaction, when it should be plus 1.
Reinstalling to latest version doesn't fix it.
Waiting minutes closing re-opening the desktop app doesn't fix it.

What is the issue, has this issue always been in the app?

@Hero-Gamer
Copy link
Author

about 15~20 minutes later, the 1st tx still "in mempool" spinning status, now if I attempt the 2nd tx the nonce is set correctly.

@314159265359879 314159265359879 added the Bug 🐛 Functionality broken label May 11, 2023
@github-project-automation github-project-automation bot moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) May 27, 2023
@314159265359879 314159265359879 moved this from Enhancements backlog to Triage in Hiro Wallet (DEPRECATED) May 27, 2023
@314159265359879 314159265359879 added the P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds label May 27, 2023
@314159265359879
Copy link

This bug is still in version 4.10.0 of the wallet
image

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Jun 2, 2023

This new API support for getting mempool nonces seems promising for improving our nonce calculations: hirosystems/stacks-blockchain-api#1633

@fbwoolf wdyt since it appears you were the one that submitted the API-side issue that led to this PR last fall?

Presumably it'd help both in the desktop and extension versions.

@markmhendrickson markmhendrickson changed the title nonce not set correctly on next new tx Resolve nonce issues with new mempool nonces from API? Jun 2, 2023
@fbwoolf
Copy link
Collaborator

fbwoolf commented Jun 2, 2023

hirosystems/stacks-blockchain-api#1633

Yeah, I think we should try to use. We do it ourselves using pending transactions query, but would help to know what the api sends us.

@314159265359879
Copy link

314159265359879 commented Oct 23, 2023

We get reminded now and again that this bug is still in the current wallet.

It can take upto 10 minutes before the desktop wallet updates the next nonce after a transaction is send. On the extension this behavior is much better (takes less time to update).

@Hero-Gamer
Copy link
Author

I waited more than 10 minutes this time before new tx is able to recognize the correct next nonce.

@markmhendrickson markmhendrickson added P2 Bug 🕷 Critical functionality broken for few users, with no clear workarounds and removed P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds labels Oct 24, 2023
@314159265359879
Copy link

Resolving this issue will not get prioritized yet. We have revamping the desktop wallet on our roadmap for Q2 2024, this will likely have to wait until that time.

Note that the team is focusing on improving support in hardware/Ledger mode and building the mobile version of Leather at the moment. Some of that work also involves making choices that benefit the desktop wallet later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Functionality broken Nonce P2 Bug 🕷 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Development

No branches or pull requests

4 participants