Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen use of zxcvbn with additional input to minimize risk of weak passwords #1225

Open
fpbgg opened this issue Sep 5, 2023 · 2 comments

Comments

@fpbgg
Copy link

fpbgg commented Sep 5, 2023

https://github.com/leather-wallet/desktop/blob/c362a6675e25e701bfc80fdab84fe8c2354ec1a0/app/crypto/validate-password.ts#L25-L28

The zxcvbn library accepts an optional list of user inputs (e.g. username or email address). Providing this will prevent someone from setting weaker passwords than expected from a naive password evaluation.

@kyranjamie
Copy link
Collaborator

We don't have username, nor email address.

@markmhendrickson
Copy link
Collaborator

@fpbgg given we don't collect these sorts of values otherwise, is there another type of input we could use here in your mind?

@markmhendrickson markmhendrickson changed the title Provide email address to zxcvbn to minimize risk of weak passwords Strengthen use of zxcvbn with additional input to minimize risk of weak passwords Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants