Remove expired usernames from display on "choose accounts" screen

[markmhendrickson]

Perhaps adding a link to documentation about renewing or re-buying expired usernames.

[jasperjansz]

https://www.figma.com/file/aXnNi8MOmN3CDrVwaDXXuqX3/Authenticator?node-id=7829%3A89907

[aulneau]

I'm not sure hiding or disabling them would be the right course to choose. Even if a username is expired, the account could still use apps that don't require them

[markmhendrickson]

That's a good point. Perhaps we should flag that expiration and provide a path for renewal, but otherwise allow the user to authenticate with just the associated address.

[aulneau]

otherwise allow the user to authenticate with just the associated address.

just to clarify, regardless of if an account has a username, the associated address is what is always authenticating.

[hstove]

just to clarify, regardless of if an account has a username, the associated address is what is always authenticating.

👍🏼 I think the main issue is that @stacks/auth will fail if an expired username is included in the authResponse, so simply being smarter about that (and not including the username) is the main impact

[markmhendrickson]

Expired names should no longer impede the selection of accounts for app authentication now that @janniks has removed username-checking from auth in general with #2333.

However, these expired names still do appear on the "choose accounts" screen. I've renamed this issue to focus on their removal from there, reverting back to "Account N" just as how things work on the home screen as desired: