Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked from sending BTC to yourself #5349

Open
brandonmarshall-tm opened this issue May 7, 2024 · 5 comments
Open

Blocked from sending BTC to yourself #5349

brandonmarshall-tm opened this issue May 7, 2024 · 5 comments
Assignees
@pete-watters
Labels
area:bitcoin area:send enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives extension
Milestone
Redesign send UX

Comments

@brandonmarshall-tm
Copy link

A user was trying to send BTC to themselves to consolidate UTXOs, but Leather blocked them from doing so.

It might better to give a warning that you are sending to yourself, and still allow you to proceed, versus blocking the user from doing it entirely. There are real use cases where one may want to send to themselves.

Screenshot 2024-05-07 at 9 20 07 AM
@brandonmarshall-tm brandonmarshall-tm added area:bitcoin enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives area:send labels May 7, 2024
@markmhendrickson markmhendrickson added this to the Redesign send UX milestone May 13, 2024
@brandonmarshall-tm brandonmarshall-tm added enhancement-p2 Critical functionality needed by few users, with no clear alternatives and removed enhancement-p4 Non-critical functionality wanted by few users, or there are clear alternatives labels Nov 30, 2024
@brandonmarshall-tm
Copy link
Author

Upping this to a P2 as there are no clear alternatives other than using a different wallet or paying more.

As BTC fees climb, users will find opportunities to consolidate UTXOs during times of low fees. We should not block users from sending to themselves.

@pete-watters
Copy link
Contributor

Upping this to a P2 as there are no clear alternatives other than using a different wallet or paying more.

As BTC fees climb, users will find opportunities to consolidate UTXOs during times of low fees. We should not block users from sending to themselves.

Can users just create a new account on the wallet and send funds there? That would consolidate their UTXOs albeit at a different address. They can send it to themselves, just not to the same address

@brandonmarshall-tm
Copy link
Author

Yes technically correct, just double the fees required if they want to keep the same wallet. It just feels like an arbitrary rule we have in place when a warning should suffice

@pete-watters
Copy link
Contributor

Yes technically correct, just double the fees required if they want to keep the same wallet. It just feels like an arbitrary rule we have in place when a warning should suffice

Agreed and it could even be a nice feature to offer in its own right - UTXO consolidation

@camerow camerow added the extension label Jan 7, 2025 — with Linear
@camerow camerow removed the extension label Jan 7, 2025
@camerow camerow added the extension label Jan 7, 2025 — with Linear
@camerow camerow added the enhancement label Jan 7, 2025 — with Linear
pete-watters added a commit that referenced this issue Jan 27, 2025
@pete-watters
fix: allow usersto send btc to themselves, ref #5349
8e19353
pete-watters added a commit that referenced this issue Jan 27, 2025
@pete-watters
fix: allow users to send btc to themselves, ref #5349
9293d3f
@pete-watters pete-watters self-assigned this Jan 27, 2025
@pete-watters
Copy link
Contributor

I've removed validation that was blocking users from sending BTC to their own address in this PR. I've kept the validation for STX as that network does not support it.

This means users will now be able to send BTC to themselves and this consolidate their UTXOs

pete-watters added a commit that referenced this issue Jan 27, 2025
@pete-watters
fix: allow users to send btc to themselves, ref #5349
a04841d
@pete-watters pete-watters mentioned this issue Jan 27, 2025
Merged
kyranjamie pushed a commit that referenced this issue Jan 28, 2025
@semantic-release-bot
chore(release): 6.60.0
8c532b5 
## [6.60.0](v6.59.2...v6.60.0) (2025-01-28)

### Features

* **signPsbt:** add txid to return payload, closes [#5292](#5292) ([c19a902](c19a902))

### Bug Fixes

* allow users to send btc to themselves, ref leather-io/extension[#5349](#5349) ([a04841d](a04841d))
* go close ledger action navigation, LEA-2078 ([a950b32](a950b32))
* **rpc:** use SIP-30 format for `stx_signTransaction` ([99b84d3](99b84d3))
* sbtc swap validation ([7de260e](7de260e))
* stx available balance issues ([6f054bb](6f054bb))

### Internal

* post-release merge back ([2b43e49](2b43e49))
* update path-to-regexp to fix ci audit ([9e4544d](9e4544d))
* upgrade utils package ([6e6d17e](6e6d17e))
pete-watters added a commit that referenced this issue Jan 28, 2025
@pete-watters
fix: show available metadata for stacks nfts, ref #5349
7b0f38c
pete-watters added a commit that referenced this issue Jan 28, 2025
@pete-watters
fix: show available metadata for stacks nfts, ref #5349
37efb5b
pete-watters added a commit that referenced this issue Feb 4, 2025
@pete-watters
fix: show available metadata for stacks nfts, ref #5349
510b1bd
pete-watters added a commit that referenced this issue Feb 4, 2025
@pete-watters
fix: show available metadata for stacks nfts, ref #5349
30a2d8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:bitcoin area:send enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives extension
Projects
None yet
Milestone
Redesign send UX
Development

No branches or pull requests
4 participants
@markmhendrickson @pete-watters @camerow @brandonmarshall-tm