Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance sheet no longer reports 'Current Earnings' #7785

Closed
cricalixwood opened this issue Dec 8, 2023 · 4 comments · Fixed by #7798
Closed

Balance sheet no longer reports 'Current Earnings' #7785

cricalixwood opened this issue Dec 8, 2023 · 4 comments · Fixed by #7798
Labels
type:blocking Deemed "needs to be fixed before the assigned release"; unacceptable regressions or critical bugs type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)

Comments

@cricalixwood
Copy link

Version

1.11.4

What browsers are you seeing the problem on?

Firefox

What happened?

Upgraded database from 1.10.25 to 1.11.4. No transactions entered. Template for Balance Sheet not changed for this database. (I had changed it for other companies). Balance sheet on 1.10.25 shows 'Current earnings' under Equity, so Total Equity plus Total Liabilities = Total Assets. On 1.11.4 the balance sheet numbers all agree, except that the Current Earnings line is missing, so the Balance Sheet does not balance.

What should have happened?

I am expecting to see a line for Current Earnings, as in 1.10.25
@cricalixwood
Copy link
Author

Just upgraded 1.11.4 to 1.11.5. Issue remains.

@ehuelsmann
Copy link
Member

Thanks for testing! I think I identified the problem and am working on a fix for 1.11.6

@ehuelsmann ehuelsmann added type:blocking Deemed "needs to be fixed before the assigned release"; unacceptable regressions or critical bugs type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0) labels Dec 9, 2023
@cricalixwood
Copy link
Author

cricalixwood commented Dec 9, 2023 via email

ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Dec 10, 2023
@ehuelsmann
Don't filter accounts too early; it prevents current earnings calcula…
ffe66be 
…tions

Fixes ledgersmb#7785
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Dec 10, 2023
@ehuelsmann
Don't filter accounts too early; it prevents current earnings calcula…
72cc700 
…tions

Fixes ledgersmb#7785
This was referenced Dec 10, 2023
Merged
Merged
@cricalixwood
Copy link
Author

cricalixwood commented Dec 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:blocking Deemed "needs to be fixed before the assigned release"; unacceptable regressions or critical bugs type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't filter accounts too early; it prevents current earnings calculations ehuelsmann/LedgerSMB
2 participants
@ehuelsmann @cricalixwood