Skip to content

Data picker modal doesn't bypass selected values #491

@ihorleleka

Description

@ihorleleka

Which Contentment version are you using?

v6(latest alpha)

Which Umbraco version are you using? For example: 13.2.1 - don't just write v13

16.2.0

Bug summary

https://github.com/leekelleher/umbraco-contentment/blob/dev/v6.x/src/Umbraco.Community.Contentment.Client/src/property-editor-ui/data-picker/data-picker-modal.element.ts

when composing this query for data picker modal:
const query = {
alias: this._propertyAlias,
dataTypeKey: this._dataTypeKey,
id: this._entityUnique,
pageNumber: this._pageNumber,
pageSize: this.data?.pageSize ?? 12,
query: this._query,
variant: this._variantId,
};

it feels like it's missing
values: this.data?.value, so that it can be bypassed to DataPickerController and then respectively to IDataPickerSource2 based search function (which would allow to exclude already selected items from search results).

Steps to reproduce

I don't have this repo forked, but it's a 1liner fix, so maybe you could just introduce it.
I've tried to explain in bug summary what's missing

Expected result / actual result

Data picker modal on initialization and search calls bypasses already selected values, so they can be handled by IDataPickerSource2 search function correctly.

Do you have Umbraco ModelsBuilder enabled?

  • Yes, it is enabled.

What browsers are you seeing the problem on?

Chrome, Edge, Firefox, Safari

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions