Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decompsition-host #63

Open
astrochenzhiqiang opened this issue Jan 7, 2024 · 1 comment
Open

decompsition-host #63

astrochenzhiqiang opened this issue Jan 7, 2024 · 1 comment

Comments

@astrochenzhiqiang
Copy link

Dear Guo
Thank you for your code, it is really a useful tool. When i run the example, i select the parameter "decompose-host = True",it will back an error like the picture
error
and if i select "decompose-host = False" it will get a result but i do not believe it.
I am a beginner in python.this may be a silly question but i appreciate your help.
Thank you!

@WenkeRen
Copy link
Contributor

WenkeRen commented Feb 7, 2024

Sorry for the late reply.

Firstly, I would recommend you to use the latest version of code (Either the master version or the released v2.0 is OK). The new version code has changed the code structure and fixed a lot of fatal bugs. I separate the host decomposition in v2.0+ and make it more flexible and reasonable.

Besides, I checked our example.ipynb in v1.1, the decompose_host parameter is switched on by default in all example blocks. It should be able to run well if you are using the default setting at least. Its been a long time since the publish of v1.1, not sure but we should have test it thoroughly. I'd like to know if your change some other things like, do you change the initialization code or using spectra from other telescope instead of SDSS. The data type of the input as well as the spectra length could cause the error, especially in old version. (So I strongly suggest you to use the new version)

You can also contact me directly from email: rwk at mail.ustc.edu.cn
Currently I will have more time working on the code maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants