Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft version can overwrite different diagram #26

Open
nerdingasnate opened this issue May 22, 2020 · 1 comment
Open

draft version can overwrite different diagram #26

nerdingasnate opened this issue May 22, 2020 · 1 comment
Labels
bug Something isn't working Hacktoberfest

Comments

@nerdingasnate
Copy link

To reproduce:

  1. create a diagram {{drawio>test:test1}}
  2. edit the diagram and save
  3. edit the diagram and exit without saving/discarding (or just leave it open)
  4. on another tab create a diagram {{drawio>test:test2}} (or just choose a different pre-existing one)
  5. when opening the diagram test2 you will get - A version of this diagram is available... if you click ok and save it you will have overwritten diagram test2 with diagram test1
@lejmr
Copy link
Owner

lejmr commented May 23, 2020

Good catch :-)

I will articulate the bug as: a draft version of a diagram is used no matter the diagram name. In other words, we should better validate the id of edited diagram when a draft is used.

@lejmr lejmr added the bug Something isn't working label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants