Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pelago/emogrifier dependency #16

Open
samandeggs opened this issue Oct 16, 2024 · 4 comments
Open

Upgrade pelago/emogrifier dependency #16

samandeggs opened this issue Oct 16, 2024 · 4 comments

Comments

@samandeggs
Copy link

Hi - Having issues if trying to use PHP 8.3, as pelago/emogrifier 6.0.0 requires a maximum of php8.1.0 - presumably this could be part of a SS5 upgrade, doubt there's much here to make it SS5 compatible other than this conflict to allow for php8.3 support.

@samandeggs
Copy link
Author

@lekoala actually, likely requires a full dependency update to support SS5 - would be greatly appreciated

@lekoala
Copy link
Owner

lekoala commented Oct 16, 2024

actually, silverstripe 5 requires a whole other setup since it's using another mailer, see
#14

Adjusting for pelago/emogrifier should be easy enough, i could even make that dependecy optional or set ^6|^7 if that works

@samandeggs
Copy link
Author

It may I'm not entirely sure. If you think that there are bigger issues at play here with SS5 not being supported, that was the ultimate goal with beating this issue. Happy to test it out if you do make that alteration.

Thanks for your time.

@lekoala
Copy link
Owner

lekoala commented Oct 16, 2024

i changed it to ^6|^7 on master at least installing should work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants