Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes Endpoint #140

Closed
lelouchB opened this issue Nov 15, 2020 · 13 comments
Closed

Quotes Endpoint #140

lelouchB opened this issue Nov 15, 2020 · 13 comments
Assignees
Labels
backend documentation Improvements or additions to documentation enhancement New feature or request frontend good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@lelouchB
Copy link
Owner

What is this ./endpoint about ?
Final Space has some great fun quotes by its characters.
This endpoint will be sending quotes.

Maybe after initial setup add a filter that will send quotes from a specific character.

What is the schema ?

quote : 'Quote',
by : 'Name of character',
character : 'URL to that character endpoint',
image: 'URL to Character Image'
@lelouchB lelouchB added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs backend frontend labels Nov 15, 2020
@lelouchB lelouchB pinned this issue Nov 15, 2020
@Mayank0255
Copy link
Contributor

@lelouchB could I try this one?

P.S. - I am new to Open Source Contribution, but, I am not new to web development with React, Node.js and MongoDB

@lelouchB
Copy link
Owner Author

@Mayank0255
Ofcourse
This is the endpoint suggestion issue of Quotes endpoint

Can you comment on #141 so I can assign it to you

Thanks

@Mayank0255
Copy link
Contributor

@lelouchB sure will do that right away and kindly explain it to me a little that you want this endpoint to be built with our imagination right? You have provided us what it should do and a brief about the schema

@lelouchB
Copy link
Owner Author

@lelouchB sure will do that right away and kindly explain it to me a little that you want this endpoint to be built with our imagination right? You have provided us what it should do and a brief about the schema

Answered here #141 (comment)

@Mayank0255
Copy link
Contributor

@lelouchB

After you would have added the quotes data to the database, could you provide me with the .env file as or else to test out the endpoints I would have to add some data of my own

@lelouchB
Copy link
Owner Author

@lelouchB

After you would have added the quotes data to the database, could you provide me with the .env file as or else to test out the endpoints I would have to add some data of my own

Are you talking about testing quotes endpoint or all endpoints in general ?

@Mayank0255
Copy link
Contributor

Mayank0255 commented Nov 17, 2020

Are you talking about testing quotes endpoint or all endpoints in general ?

@lelouchB Ya I'm talking about that only

@lelouchB
Copy link
Owner Author

For active endpoints you can run npm run seed in the backend directory which will fill your local MongoDB collection with data from API
You can manually add quotes to that collection for local development.

Refer here.

"seed": "node ./helpers/seeder.js"

@Mayank0255
Copy link
Contributor

Cool got it

@lelouchB
Copy link
Owner Author

@Mayank0255
Quotes endpoint is live.

Thanks to your contribution, I was able to ship it into production.

https://finalspaceapi.com/blog/quote
https://finalspaceapi.com/api/v0/quote

@lelouchB lelouchB unpinned this issue Nov 18, 2020
@Mayank0255
Copy link
Contributor

Mayank0255 commented Nov 18, 2020

@lelouchB

Thanks a lot Ashutosh and the mention on the blog also means a lot.

Looking forward to work with you in future as well.

@lelouchB
Copy link
Owner Author

NP
👍
If you want you can also create an example for this endpoint under the Examples section
#32

Thanks :)

@Mayank0255
Copy link
Contributor

NP
👍
If you want you can also create an example for this endpoint under the Examples section
#32

Thanks :)

Not at the moment but will ping you later on if I get time for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation enhancement New feature or request frontend good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants