Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 Page #29

Closed
lelouchB opened this issue Oct 6, 2020 · 17 comments
Closed

Add 404 Page #29

lelouchB opened this issue Oct 6, 2020 · 17 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@lelouchB
Copy link
Owner

lelouchB commented Oct 6, 2020

There is no 404 page, so add one. #27

Head to https://finalspaceapi.com/404
Thanks @mahendrarathore1742 for this issue.

Error expected :
image

@lelouchB lelouchB self-assigned this Oct 6, 2020
@lelouchB lelouchB added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 6, 2020
@lelouchB lelouchB mentioned this issue Oct 6, 2020
@lelouchB lelouchB removed their assignment Oct 6, 2020
@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

hey @mahendrarathore1742
Comment on this issuse so I can assign it you.
Thanks

@mahendrarathore1742
Copy link

keep it up sir , you can do it,

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Hey @mahendrarathore1742
I don't quite follow.

Looking forward to your contributions

@ayush-git228
Copy link

Can I contribute to this.

@Skr-suyash
Copy link
Contributor

I would like to contribute on this. It is nearly completed so please assign this to me

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

Hey @ayush-git228
@mahendrarathore1742 is working on this issue.

I just created a new issue #31 let me know if you are interested in that issue.

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

@Skr-suyash
Like I said @mahendrarathore1742 is working on this
If you are done with your commit, feel free to send a PR.

I will take a look at your PR and @mahendrarathore1742 PR, merge both of them and revert one
This is only if you have completed this issue.

Thanks

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 6, 2020

@Skr-suyash and @ayush-git228
#31 is no longer available
But you can contribute to #32
Since there can be many examples, you both can contribute to it.

Thanks

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 7, 2020

Hey @mahendrarathore1742
What is the progress on this?

@mahendrarathore1742
Copy link

Hey @mahendrarathore1742
What is the progress on this?

almost done!

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 8, 2020

@mahendrarathore1742
Any word on this?

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 9, 2020

@mahendrarathore1742
Since there is no update, I am unassigning you.

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 9, 2020

@Skr-suyash
Still interested in this?

@Skr-suyash
Copy link
Contributor

Sure, I can do this but I am not able to understand how to add a 404 page to be displayed in Docasaurus

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 9, 2020

@Skr-suyash
Here is a resource on this, take your time. Go through them and try to implement them and let me know
https://v2.docusaurus.io/docs/static-assets/#caveats

Alternatively you can try exploring dousaurus GitHub repo for a fix.

@Skr-suyash
Copy link
Contributor

I would like to work on this, let us see if it works. 😅

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 9, 2020

I would like to work on this, let us see if it works. 😅

Go for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants