Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules.mk: use long --family-suffix= option to avoid ambiguity with '-G' #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthrotype
Copy link

This is a minor patch which doesn't change the result of the ttfautohint command.

It is just to allow me to use the noto-hinted repository to test that my Python wrapper for ttfautohint produces identical results as the original ttfautohint executable.

Apparently, with python's argparse module (used to parse command line options) the following string, which in the makefile rules for noto-hinted is meant to append the "-G" suffix to the family names:

$ ttfautohint -F -G ...

.. is interpreted by argparse as an -F option without its required positional argument (hence an error) and that is followed by the -G option (or --hinting-limit PPEM in its long form).

See https://bugs.python.org/issue9334

The workaround is to use the long form with the equal sign, e.g. --family-suffix="-G", which works in both python and ttfautohint native executable.

Another minor thing is the use of -p option with mkdir to prevent error message in case folder already exists.

use -p option with mkdir to prevent error message in case folder already exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant