rules.mk: use long --family-suffix= option to avoid ambiguity with '-G' #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor patch which doesn't change the result of the ttfautohint command.
It is just to allow me to use the noto-hinted repository to test that my Python wrapper for ttfautohint produces identical results as the original ttfautohint executable.
Apparently, with python's
argparse
module (used to parse command line options) the following string, which in the makefile rules for noto-hinted is meant to append the "-G" suffix to the family names:.. is interpreted by argparse as an
-F
option without its required positional argument (hence an error) and that is followed by the-G
option (or--hinting-limit PPEM
in its long form).See https://bugs.python.org/issue9334
The workaround is to use the long form with the equal sign, e.g.
--family-suffix="-G"
, which works in both python and ttfautohint native executable.Another minor thing is the use of -p option with mkdir to prevent error message in case folder already exists.