Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action-decorators: TypeError: Cannot redefine property: willTransition #6

Open
Turbo87 opened this issue Oct 16, 2019 · 0 comments
Open

action-decorators: TypeError: Cannot redefine property: willTransition #6

Turbo87 opened this issue Oct 16, 2019 · 0 comments

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 16, 2019

After applying the action-decorators codemod and running our test suite I'm seeing the following error:

TypeError: Cannot redefine property: willTransition

It seems that these sorts of actions on Route instances are not supposed to be used with the action decorator.

I would propose to blacklist all the events from https://api.emberjs.com/ember/3.13/classes/Route/events and not convert those to actions using action().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Turbo87