Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make whole pylxca code in accordance with PEP8 style guide by using pylint #1

Open
walteraa opened this issue Mar 18, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@walteraa
Copy link

When running Pylint, for example, in the file pylxca/lxca_cmd.py, I got the following report summary:

------------------------------------
Your code has been rated at -1.95/10

It occurs because some style recommendations aren't followed, for example:

I changed the class name in line 285 from fans to Fan and I ran the pylint again, getting the following report:

--------------------------------------------------------------------
Your code has been rated at -1.82/10 (previous run: -1.95/10, +0.13)

Increasing 0.13% the code quality. It happened because class name should have the first line in upper case and shouldn't be in plural, only collections should be plural, even it referring to a class which has a list command, which the recommendation is use something like that:

pylxca fan list or pylxca fan get ID

@rodneyhbrown7
Copy link

Thanks Walter.

@navalkp navalkp assigned Aamit1987 and unassigned prabhosa and navalkp Apr 23, 2018
@prabhosa prabhosa added this to the 4/30 milestone Apr 23, 2018
@prabhosa prabhosa assigned prabhosa and unassigned Aamit1987 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants