-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Version 3.0 broke shell completion and is less readable #689
Comments
I created PR #690, which should help with this in some cases, but it seems that the completion you referenced will have to be updated for version 3.0. I am working on an API command to provide clean JSON outputs for actions like listing releases and projects. However, I am not sure if this will be helpful. I would like to make the completions compatible with 3.0 without completely changing the output. I am unsure if this is possible. |
Thanks, but unfortunately PR #690 is not exactly what I want. I personally am not a fan of the
I think it will, but as you said, it will require (more) work to make the completion script work again. Also, if I may ask, what was the rationale for adding the colored boxes and stuff to output? |
Actually I think we can make shell completion work when you integrate I'm happy to help with making it work once you merge PR #690 |
I went ahead and merged it. Also, I am working on a JSON API for fvm to return clean JSON for specific commands. |
So I investigated a bit and looks like it's not as simple as I thought. The main problem is that the
This would imply that the completions will be able to parse that JSON. I think the easiest solution is to add a plaintext mode to commands that output some data (e.g. |
@bartekpacia do you think the JSON api resolves this problem? |
It's a step in the right direction but outputting JSON means that the completion script must be able to parse that json, thus requiring Plain text is the universal interface of the command line. |
@bartekpacia I agree, the main goal is to provide an interface that can be maintained. As the logging and output can sometimes change. We can create a flag to return not as json, but as plaintext, let me know what formatting would work for you. |
Before creating a bug report please make check the following
pub cache repair
. Close the terminal and try again.administrator
or withdeveloper
permissions.fvm doctor
if possible and add the output to the issue.Describe the bug
I noticed that
fvm
changed its UI a lot in v3. Now there are borders around everything. I understand some may like it, but I really don't – I wish there was a way to disable it, or that an earlier UI could be restore without impacting functionality.fvm list - before
fvm list - after
I prefer the first UI style much more - it's simpler, takes less space, and is easier to parse. I appreciate however more information provided by the second UI style.
But what's worse is that fvm v3 broke the unofficial Zsh shell completion script (source).
It used to work great, like this (example of
fvm install <TAB>
):Screen.Recording.2024-03-11.at.01.34.19.mov
but now it breaks, likely because of the addition of colored borders:
bug.mov
To Reproduce
Use TAB shell completion on fvm v3. For example, try
$ fvm install <TAB>
and notice how it breaks.Expected behavior
.fvmrc
would be great.Desktop
Additional context
I very much appreciate the awesome work you're doing with
fvm
- thank you. I am willing to help contribute this if you agree.The text was updated successfully, but these errors were encountered: