Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding my own Quick App to sites.conf: only 1 file extracted #191

Closed
ltguillaume opened this issue Aug 5, 2020 · 2 comments
Closed

Adding my own Quick App to sites.conf: only 1 file extracted #191

ltguillaume opened this issue Aug 5, 2020 · 2 comments
Assignees
Labels
bug fixed-7.0.4 Fixed in version 7.0.4
Milestone

Comments

@ltguillaume
Copy link

ltguillaume commented Aug 5, 2020

I was trying to add the line

Music Folder Player=https://github.com/ltGuillaume/MusicFolderPlayer/archive/master.zip

to sites.conf in order to see if I could create my own Quick App. Unfortunately, after downloading the zip file, I found Laragon only extracted a single file to the destination folder: it only extracted the file in .zip\MusicFolderPlayer-master\music.pls\README.md to the destination root (so not in \music.pls\) and ignored all others in .zip\MusicFolderPlayer-master.

What's more, it would be useful is something like

Music Folder Player=https://github.com/ltGuillaume/MusicFolderPlayer/archive/master.zip Database=false

would define that Laragon shouldn't autocreate a database.

I think it would be quite useful if the Quick App feature would know how to extract GitHub zip files of master trees.

Another small related issue is that when the use has disabled MySQL in the settings and AutoCreateDatabase=true,
image
shows up even when the user has indeed clicked [Start All]. So the message is a tad unclear in this case.

Related: #76

@alxndr-w
Copy link
Collaborator

@leokhoa I tried to check if this was solved in Laragon 6.0 (!) adding these lines to packages.conf:

# Test
# https://github.com/leokhoa/laragon/issues/191
Music Folder Player=https://github.com/ltGuillaume/MusicFolderPlayer/archive/master.zip Database=false

This was the result:

Image

Can you check if this will work in Laragon 7 or fix it, if it's still not working?

@alxndr-w alxndr-w added the bug label Jan 27, 2025
@leokhoa leokhoa added this to the Laragon 7.1 milestone Jan 29, 2025
@leokhoa leokhoa added fixed-in-next-release fixed in next release fixed-7.0.4 Fixed in version 7.0.4 and removed fixed-in-next-release fixed in next release labels Jan 29, 2025
@leokhoa
Copy link
Owner

leokhoa commented Jan 29, 2025

This issue is fixed in version 7.0.4.
Quick-app currently doesn't support Database=false, but I've created a sub-issue to address this enhancement:
#1001

@leokhoa leokhoa closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed-7.0.4 Fixed in version 7.0.4
Projects
None yet
Development

No branches or pull requests

3 participants