-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature suggestion: Translating updated strings again #8
Comments
Hey @petrchutny, thanks for your feedback! It's awesome to see this tool being used in real-world products! I'm guessing that you're using key-based translation, like: {
"SOME_TEXT": "This is a string",
"OTHER_TEXT": "This is another string"
} To be able to detect changes, json-autotranslate would need to keep a kind of cache folder containing the latest translated version of files and compare them to the current ones. This feature has already kind of been requested in #5 and I will try to implement a good solution for it this week. Thinking about it, keeping the last translated version would also allow json-autotranslate to detect which translations have been manually edited and warn the user if they would be overwritten by a command. |
Thanks for your reply :) Yes, we’re using it for key-based translation. That’s great that you’re up for doing it! Your idea with the warnings is also very good.
All the best & thanks,
—
Petr Chutný
petrchutny.cz
…On 4 Nov 2019, 23:53 +0800, Leo Bernard ***@***.***>, wrote:
Hey @petrchutny,
thanks for your feedback! It's awesome to see this tool being used in real-world products!
I'm guessing that you're using key-based translation, like:
{
"SOME_TEXT": "This is a string",
"OTHER_TEXT": "This is another string"
}
To be able to detect changes, json-autotranslate would need to keep a kind of cache folder containing the latest translated version of files and compare them to the current ones.
This feature has already kind of been requested in #5 and I will try to implement a good solution for it this week.
Thinking about it, keeping the last translated version would also allow json-autotranslate to detect which translations have been manually edited and warn the user if they would be overwritten by a command.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I've implemented this in v1.5.0, check it out if you like :) |
So the cache folder should be kept as part of source control? I ignored it as I assumed it was temp folder, make sense now that I read this. |
Ah, yes :) |
Hmm .json-autotranslate-history |
For One thing that I am not yet sure about is the number of required caches. |
Hello,
thanks for making this amazing script. It helps us greatly to save so much time translating at Tinkamo. I know this might be a big idea requiring more coding, but what do you think about the functionality of being able to detect whether a source string has changed and translating it again?
What do you think about it? :)
The text was updated successfully, but these errors were encountered: