Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault not aware of top circuit uniquification #338

Open
leonardt opened this issue Mar 15, 2024 · 0 comments
Open

Fault not aware of top circuit uniquification #338

leonardt opened this issue Mar 15, 2024 · 0 comments

Comments

@leonardt
Copy link
Owner

Remove this line to reproduce: https://github.com/phanrahan/magma/blob/master/examples/odd_even_sort.py#L92-L93

Fault will assume the top circuit has the non-uniquified name, which causes issues when the top circuit doesn't receive the original name (i.e. when _unq{n} is appended). Ideally fault refers to the post uniquification name (perhaps we can allow fault to run the compiler passes earlier?), alternatively we might have fault force/pin the name of the top circuit (at least in this case, other circuits will still receive a unique name, but it may not map 1-1 with the default RTL generation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant