Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for Storage and Network #24

Open
TRomesh opened this issue Sep 5, 2019 · 2 comments
Open

Add more unit tests for Storage and Network #24

TRomesh opened this issue Sep 5, 2019 · 2 comments
Labels

Comments

@TRomesh
Copy link
Collaborator

TRomesh commented Sep 5, 2019

  • Follow the same pattern used in the existing unit tests
@TRomesh TRomesh added the GCI label Sep 5, 2019
@duc0905
Copy link

duc0905 commented Dec 8, 2019

Hi, I just want to be clear about the task.
The goal of the task is creating unit tests for others providers, gcp and azure, for storage and network services. So basically, I have to add more test in storage.test.js and network.test.js and create Gcpmock.js and Azuremock.js file for those tests.
Please tell me whether I am mistaken.

@TRomesh
Copy link
Collaborator Author

TRomesh commented Dec 8, 2019

Hi, I just want to be clear about the task.
The goal of the task is creating unit tests for others providers, gcp and azure, for storage and network services. So basically, I have to add more test in storage.test.js and network.test.js and create Gcpmock.js and Azuremock.js file for those tests.
Please tell me whether I am mistaken.

@duc0905 Yes you can create mock files and write tests. You can write more test for network.test.js
by looking for the methods which has no test written under network.js.
i.e
network.test.js has only 4 tests but network.js has more methods, Write test for the reaming methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants