From 0ed1635e4adf87c119a6d19e7bb2eaa04283acd1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?L=C3=A9r=C3=A8?= <lere.williams@gmail.com>
Date: Sat, 2 Mar 2024 15:21:16 -0800
Subject: [PATCH] Mitigate race condition around setting size labels

By fetching labels from the API just before we apply them, we reduce the
chance that the set of labels has changed since the workflow started.
---
 __tests__/main.test.ts |  5 +++--
 badges/coverage.svg    |  2 +-
 dist/index.js          |  7 ++++++-
 src/main.ts            | 11 ++++++++++-
 4 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
index 315d725..c3a8273 100644
--- a/__tests__/main.test.ts
+++ b/__tests__/main.test.ts
@@ -34,7 +34,6 @@ function pullRequestEventContext(overrides = {}): object {
         head: {
           ref: 'topic'
         },
-        labels: [],
         number: 1,
         user: {
           login: 'lerebear'
@@ -51,10 +50,12 @@ describe('action', () => {
   jest.spyOn(github, 'getOctokit').mockImplementation((token: string): any => {
     if (token === 'xxx') {
       return {
+        paginate: () => [],
         rest: {
           issues: {
             getLabel: () => {},
-            addLabels: () => {}
+            addLabels: () => {},
+            listComments: () => {}
           }
         }
       }
diff --git a/badges/coverage.svg b/badges/coverage.svg
index 2bd6b8f..337ea38 100644
--- a/badges/coverage.svg
+++ b/badges/coverage.svg
@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="116" height="20" role="img" aria-label="Coverage: 64.74%"><title>Coverage: 64.74%</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="116" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="63" height="20" fill="#555"/><rect x="63" width="53" height="20" fill="#e05d44"/><rect width="116" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="325" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="530">Coverage</text><text x="325" y="140" transform="scale(.1)" fill="#fff" textLength="530">Coverage</text><text aria-hidden="true" x="885" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="430">64.74%</text><text x="885" y="140" transform="scale(.1)" fill="#fff" textLength="430">64.74%</text></g></svg>
\ No newline at end of file
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="116" height="20" role="img" aria-label="Coverage: 64.96%"><title>Coverage: 64.96%</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="116" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="63" height="20" fill="#555"/><rect x="63" width="53" height="20" fill="#e05d44"/><rect width="116" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="325" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="530">Coverage</text><text x="325" y="140" transform="scale(.1)" fill="#fff" textLength="530">Coverage</text><text aria-hidden="true" x="885" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="430">64.96%</text><text x="885" y="140" transform="scale(.1)" fill="#fff" textLength="430">64.96%</text></g></svg>
\ No newline at end of file
diff --git a/dist/index.js b/dist/index.js
index 9f2f46b..df21989 100644
--- a/dist/index.js
+++ b/dist/index.js
@@ -16912,7 +16912,12 @@ async function applyLabel(pull, score, config) {
     const newLabelName = `${labelPrefix}${score.category.label.name}`;
     const labelsToAdd = [newLabelName];
     const labelsToRemove = [];
-    for (const existingLabel of pull.labels) {
+    const existingLabels = await octokit.paginate(octokit.rest.issues.listLabelsOnIssue, {
+        owner: pull.base.repo.owner.login,
+        repo: pull.base.repo.name,
+        issue_number: pull.number
+    });
+    for (const existingLabel of existingLabels) {
         if (existingLabel.name === newLabelName) {
             labelsToAdd.pop();
         }
diff --git a/src/main.ts b/src/main.ts
index 3b8f2d7..eca889e 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -180,6 +180,7 @@ async function applyLabel(
   config: Configuration
 ): Promise<void> {
   const octokit = github.getOctokit(core.getInput('token'))
+
   const labelPrefix = configOrDefault(
     config.labeling?.categoryLabelPrefix,
     DEFAULT_LABEL_PREFIX
@@ -188,7 +189,15 @@ async function applyLabel(
   const labelsToAdd = [newLabelName]
   const labelsToRemove = []
 
-  for (const existingLabel of pull.labels) {
+  const existingLabels = await octokit.paginate(
+    octokit.rest.issues.listLabelsOnIssue,
+    {
+      owner: pull.base.repo.owner.login,
+      repo: pull.base.repo.name,
+      issue_number: pull.number
+    }
+  )
+  for (const existingLabel of existingLabels) {
     if (existingLabel.name === newLabelName) {
       labelsToAdd.pop()
     } else if (existingLabel.name.startsWith(labelPrefix)) {