Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate configuration against schema #17

Open
lerebear opened this issue Nov 6, 2023 · 0 comments
Open

Validate configuration against schema #17

lerebear opened this issue Nov 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@lerebear
Copy link
Owner

lerebear commented Nov 6, 2023

To help users configure this tool correctly, we should validate user-supplied configuration against our schema. This well help us catch and report structural errors more quickly.

I think this could have helped with #16, which turned out not to be a bug in this library, but rather a misplaced configuration key (the optIns key was accidentally nested under the sizeup key, where it should instead have appeared at the top level). If we encounter unexpected/misplaced keys during the validation process, we should warn on them, whereas if we find invalid values for a key we should fail the workflow.

@lerebear lerebear added the enhancement New feature or request label Nov 6, 2023
@lerebear lerebear added this to SizeUp Nov 15, 2023
@lerebear lerebear moved this to Triage in SizeUp Nov 15, 2023
@lerebear lerebear moved this from Triage to Backlog in SizeUp Nov 15, 2023
@lerebear lerebear moved this from Backlog to Triage in SizeUp Apr 5, 2024
@lerebear lerebear moved this from Triage to Backlog in SizeUp Apr 5, 2024
@lerebear lerebear moved this from Backlog to Triage in SizeUp Apr 5, 2024
@lerebear lerebear moved this from Triage to Backlog in SizeUp Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant