Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Errno::ECONNREFUSED when URL is not a valid connection #10

Open
rreinhardt9 opened this issue Jul 7, 2020 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@rreinhardt9
Copy link
Contributor

If you supply any URL for the signal_url that is a validly formatted URL but that URL isn't accepting connections (it doesn't exist, for example) it raises Errno::ECONNREFUSED.

A common way to encounter this would be if you set up a URL for an endpoint that doesn't exist yet, or maybe you make a mistake entering the URL.

When this occurs, we don't want to raise this error in the parent app. Rather, let's handle this in a similar way to how timeouts were handled in #9 and note the status on the transmission. This will allow for debugging and triggering other behavior; for example an app might want to deactivate a connection that has over a threshold of this error (hmm, that might make another nice Demux feature too 😆 )

@rreinhardt9 rreinhardt9 added the enhancement New feature or request label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant