You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since this library is used to add functionality to a core app that is then presented to those building integrations outside of the core app, it could be confusing to see the name "demux".
It would be really cool in this case to be able to customize these for specific applications, and make the current hard coded names the defaults. If we did this, we could customize the names in the case of the Lessonly app to be something like:
We could add to our configuration object so that these custom names could be set in an initializer. For example, in order to get the headers in the last example we could set the following in our initializer:
Demux.configure do |config|
config.user_agent = "LessonlyApps"
config.header_prefix = "x-lessonly"
end
These options could be added to our configuration object here
The defaults could be set in that configuration object to the current hard-coded values. Defaults could be set using fetch similar to how default_demuxer does this.
Application
We could then modify the code in Transmission to use the values from the configuration instead of hard coded values here
The text was updated successfully, but these errors were encountered:
Problem
Currently, each signal transmission that an app receives contains (among others) the following headers:
Since this library is used to add functionality to a core app that is then presented to those building integrations outside of the core app, it could be confusing to see the name "demux".
It would be really cool in this case to be able to customize these for specific applications, and make the current hard coded names the defaults. If we did this, we could customize the names in the case of the Lessonly app to be something like:
Configuration
We could add to our configuration object so that these custom names could be set in an initializer. For example, in order to get the headers in the last example we could set the following in our initializer:
These options could be added to our configuration object here
The defaults could be set in that configuration object to the current hard-coded values. Defaults could be set using
fetch
similar to howdefault_demuxer
does this.Application
We could then modify the code in
Transmission
to use the values from the configuration instead of hard coded values hereThe text was updated successfully, but these errors were encountered: