Skip to content

Commit

Permalink
Address comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
beautifulentropy committed Nov 27, 2024
1 parent 8f250ae commit 6584d5c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions va/va.go
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,10 @@ type remoteResult interface {
var _ remoteResult = (*vapb.ValidationResult)(nil)
var _ remoteResult = (*vapb.IsCAAValidResponse)(nil)

// performRemoteOperation performs the provided operation and request on all
// remote VAs. It cancels the operation and returns early if either the required
// number of successful results is obtained or the number of failures exceeds
// va.maxRemoteFailures.
// performRemoteOperation concurrently calls the provided operation with `req` and a
// RemoteVA once for each configured RemoteVA. It cancels remaining operations and returns
// early if either the required number of successful results is obtained or the number of
// failures exceeds va.maxRemoteFailures.
//
// Internal logic errors are logged. If the number of operation failures exceeds
// va.maxRemoteFailures, the first encountered problem is returned as a
Expand Down
6 changes: 3 additions & 3 deletions va/va_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ func TestPerformRemoteOperation(t *testing.T) {
ProblemType: string(probs.BadNonceProblem),
Detail: "quite surprising",
}
return &vapb.ValidationResult{Problem: prob, Perspective: rva.Perspective}, nil
return &vapb.ValidationResult{Problem: prob, Perspective: rva.Perspective, Rir: rva.RIR}, nil
},
},
{
Expand All @@ -487,7 +487,7 @@ func TestPerformRemoteOperation(t *testing.T) {
ProblemType: string(probs.PausedProblem),
Detail: "quite surprising, indeed",
}
return &vapb.IsCAAValidResponse{Problem: prob, Perspective: rva.Perspective}, nil
return &vapb.IsCAAValidResponse{Problem: prob, Perspective: rva.Perspective, Rir: rva.RIR}, nil
},
},
{
Expand All @@ -500,7 +500,7 @@ func TestPerformRemoteOperation(t *testing.T) {
ProblemType: string(probs.BadPublicKeyProblem),
Detail: "a shocking result",
}
return &vapb.ValidationResult{Problem: prob, Perspective: rva.Perspective}, nil
return &vapb.ValidationResult{Problem: prob, Perspective: rva.Perspective, Rir: rva.RIR}, nil
},
},
}
Expand Down

0 comments on commit 6584d5c

Please sign in to comment.