Calculate required in a var like PerformValidation

letsencrypt · Nov 19, 2024 · aee0ba1 · aee0ba1
1 parent a6d7f85
commit aee0ba1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/va/vampic.go b/va/vampic.go
@@ -109,6 +109,7 @@ func (va *ValidationAuthorityImpl) remoteDoDCV(ctx context.Context, req *vapb.DC
 		}(va.remoteVAs[i])
 	}
 
+	required := remoteVACount - va.maxRemoteFailures
 	var passed []string
 	var failed []string
 	passedRIRs := make(map[string]struct{})
@@ -161,7 +162,7 @@ func (va *ValidationAuthorityImpl) remoteDoDCV(ctx context.Context, req *vapb.DC
 		return summary, probs.ServerInternal("Secondary domain validation failed due to too many failures")
 	}
 
-	if len(passed) < (remoteVACount - va.maxRemoteFailures) {
+	if len(passed) < required {
 		// Too few successful responses to reach quorum.
 		if firstProb != nil {
 			firstProb.Detail = fmt.Sprintf("During secondary domain validation: %s", firstProb.Detail)