Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy rate limits code #7671

Open
1 of 9 tasks
Tracked by #5545
beautifulentropy opened this issue Aug 16, 2024 · 0 comments
Open
1 of 9 tasks
Tracked by #5545

Remove legacy rate limits code #7671

beautifulentropy opened this issue Aug 16, 2024 · 0 comments
Assignees

Comments

@beautifulentropy
Copy link
Member

beautifulentropy commented Aug 16, 2024

  • Remove nearly all of the countRegistrationsByIP, except the supporting field InitialIP in core.Registration. Default this field to "0.0.0.0" in the WFE and the SA (ratelimit: Remove legacy registrations per IP implementation #7760)
  • Remove InitialIP from core.Registration
  • Remove all code referencing certificatesPerName table
  • Remove all code referencing newOrdersRL table
  • Drop certificatesPerName and newOrdersRL tables in db-next schema
  • Deprecate DisableLegacyLimitWrites feature flag and delete all code it conditions
  • Deprecate UseKvLimitsForNewOrder flag and delete all code it conditions
  • Remove if wfe.limiter == nil && wfe.txnBuilder == nil in checkNewAccountLimits and checkNewOrderLimits WFE methods.
  • Remove if ra.limiter == nil && ra.txnBuilder == nil in countFailedValidations() and countCertificateIssued() RA methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants