Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployability: filter new lints before passing to zlint #7756

Closed
jsha opened this issue Oct 15, 2024 · 0 comments · Fixed by #7771
Closed

deployability: filter new lints before passing to zlint #7756

jsha opened this issue Oct 15, 2024 · 0 comments · Fixed by #7771
Assignees

Comments

@jsha
Copy link
Contributor

jsha commented Oct 15, 2024

Before we merge #7594, we need to deploy a config change adding e_cab_dv_subject_invalid_values and w_ext_subject_key_identifier_not_recommended_subscriber to our ignore list.

However, that's a problem because zlint 3.6.0 will error out when passed those as ignores, since they are unrecognized.

We should add special code to our config loading that filters those two specific fields before passing them to zlint. Once that's deployed, and the config change is deployed, we can revert the change as part of #7594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants