Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up NoWaitForReady #7843

Open
jsha opened this issue Nov 22, 2024 · 0 comments
Open

Clean up NoWaitForReady #7843

jsha opened this issue Nov 22, 2024 · 0 comments

Comments

@jsha
Copy link
Contributor

jsha commented Nov 22, 2024

In #6834 we added a config NoWaitForReady that allows gRPC requests to instantly error when there are no backends available (vs waiting for a backend and eventually reporting a timeout). That config is now enabled in prod. We should deprecate and ignore it, effectively never waiting for readiness. As part of that process we should also search the codebase for FailFast (which is the older gRPC terminology for the feature) and clean up relevant comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant