SA: Fix two bugs in UpdateCRLShard #7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
requested review from
jsha and
beautifulentropy
and removed request for
jsha
aarongable
force-pushed
the
improve-update-crl-shard
branch
from
7dd9d7c to
7d767c8
Compare
|
You've got a CI failure here: |
|
Yeah, I'm aware. Weirdly, it's passing locally even when run from scratch, which is wild for a--- lol, lmao, I was running t.sh instead of tn.sh locally. |
beautifulentropy
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NextUpdate field should not be required, as it is not necessary for tracking and preventing duplicate work between multiple crl-updater instances.
The ThisUpdate conditional needs explicit handling for NULL to ensure that it updates correctly.