Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va: use cancels to early-return. #7832

Merged
merged 2 commits into from
Nov 20, 2024
Merged

va: use cancels to early-return. #7832

merged 2 commits into from
Nov 20, 2024

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 19, 2024

This allows us to collect a consistent number of error results for logging.

Related to #7616.

This allows us to collect a consistent number of error results for logging.
@jsha jsha requested a review from a team as a code owner November 19, 2024 22:40
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, happy to re-ack once you fix conflicts with main.

jprenken
jprenken previously approved these changes Nov 20, 2024
@jsha jsha merged commit 01c1488 into main Nov 20, 2024
12 checks passed
@jsha jsha deleted the va-no-early-return branch November 20, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants