cmd: Make a debug listen address optional #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If provided, the CLI flag will override the value in the config file. Use the CLI flag to de-conflict parallel integration tests. Fixes #7838
beautifulentropy
previously approved these changes
Nov 22, 2024
aarongable
reviewed
Nov 25, 2024
jsha
requested changes
Nov 25, 2024
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
reviewed
Dec 4, 2024
jprenken
changed the title
|
Config change: IN-10874 |
jsha
approved these changes
Dec 10, 2024
aarongable
approved these changes
Dec 10, 2024
jsha
pushed a commit
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
debugAddrfrom theadmintool, which doesn't use it - or need it, now thatnewStatsRegistryviaStatsAndLoggingdoesn't require it.Remove
debugAddrfromconfig-next/sfe.json, as we usually set it on the CLI instead.Fixes #7838