Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logs.minEntry with a call to get-sth on first run #140

Open
Preston12321 opened this issue May 29, 2024 · 0 comments
Open

Replace logs.minEntry with a call to get-sth on first run #140

Preston12321 opened this issue May 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Preston12321
Copy link

When monitoring large, rapidly-growing logs, it becomes unwieldy to keep the minEntry config field up to date with the STH. This means that clean redeploys often result in the inclusion checker reporting unincorporated certs when, in fact, the checker simply hasn't caught up to the location in the log where its test certs were submitted. A delay of even a few days between updating the config with the then-current tree size of a log like Oak 2024h2 and re-deploying ct-woodpecker can cause this issue.

I think we should remove the minEntry field entirely, and instead use the tree size reported by get-sth to seed the StartIndex for each log's inclusion checker. This would only happen when there isn't already a non-zero index value in the database for the log, so that subsequent restarts of woodpecker don't cause the inclusion checker to jump ahead unintentionally.

@Preston12321 Preston12321 added the enhancement New feature or request label May 29, 2024
@beautifulentropy beautifulentropy self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants