Use 90 day test certs in temporal shard window #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the behavior of the test certificate generation to always create a 90 day certificate, and make sure it falls in the temporal shard window if one is defined. If issuing a certificate for a current temporal shard (where the system time + 90d `NotAfter` lands in the temporal window), then generate a certifcate based on the current time. If generating a certificate for a past or future temporal shard, then generate a 90d certificate that falls in that window. Fixes letsencrypt#127
* Update golangci-lint * Add the ability to run tests and lint manually in GitHub Actions * Add lint exclusions * Fix misspelling * Remove duplicate tls import
aarongable
previously approved these changes
Apr 3, 2023
aarongable
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of the test certificate generation to always create a
90 day certificate, and make sure it falls in the temporal shard window if
one is defined. If issuing a certificate for a current temporal shard
(where the system time + 90d
NotAfterlands in the temporal window),then generate a certifcate based on the current time. If generating a
certificate for a past or future temporal shard, then generate a 90d
certificate that falls in that window.
In addition, fix failing CI with updates and lint fixes:
Fixes #127